Skip to content

Changes

Summary

  1. tracetypes: Remove the few (long) deprecated ctors (details)
  2. scripting: Remove AnalysisScriptingModule deprecations (details)
Commit a7ab6bcc857aa16f6a03abd8affa57b52b378460 by Marco Miller
tracetypes: Remove the few (long) deprecated ctors

Remove these long deprecated constructors in OpenTracingExperiment and
TraceEventEvent, both unused. These were deprecated in commits 227b2c173
and 1f66aba9f respectively.

Fix these files formatting, based on Eclipse and Sonarlint, while being
in there. Manually reformat @NonNull for fName in TraceEventEvent.

[Removed] o.e.t.i.i.o.c.trace.OpenTracingExperiment#OpenTracingExperiment()
[Removed] o.e.t.i.i.t.c.event.TraceEventEvent#TraceEventEvent()

Change-Id: I33793b4526d4ec6c2e8c650335b34f3ff4d85b49
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/193691
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modified tracetypes/org.eclipse.tracecompass.incubator.opentracing.core/src/org/eclipse/tracecompass/incubator/internal/opentracing/core/trace/OpenTracingExperiment.java (diff)
The file was modified tracetypes/org.eclipse.tracecompass.incubator.traceevent.core/src/org/eclipse/tracecompass/incubator/internal/traceevent/core/event/TraceEventEvent.java (diff)
Commit 79ff90d9b7c4f6706d711c143a64208ea8f0dcfd by Marco Miller
scripting: Remove AnalysisScriptingModule deprecations

Add use of the existing getActiveTrace API to replace the hereby removed
(deprecated) getAnalysis. This is to be able to continue testing with a
default active (test) trace, through HeadlessScriptExecutionTest. Hence
slightly adapt testAnalysis.{js,py}, accordingly. Do the same in the
documentation code samples and files.

Adapt the related files also for the getFieldValue replacement, namely
getEventFieldValue in the reused Trace module.

Long deprecated; since commits 346e7983f, 632d83468 and 8b2cb50d8.

Slightly reformat, based on Eclipse, while being there. Do the same for
HeadlessScriptExecutionTest since used to test this change, even if not
touched per se. Slightly fix related javadoc in AnalysisScriptingModule.

[Removed] AnalysisScriptingModule#getAnalysis
[Removed] AnalysisScriptingModule#getFieldValue

Change-Id: I99288575c54ef3096e8c3fcc005c07b367834a4c
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/193694
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The file was modified scripting/org.eclipse.tracecompass.incubator.scripting.core.tests/src/org/eclipse/tracecompass/incubator/scripting/core/tests/HeadlessScriptExecutionTest.java (diff)
The file was modified scripting/org.eclipse.tracecompass.incubator.scripting.core.tests/testfiles/scripts/testAnalysis.py (diff)
The file was modified scripting/org.eclipse.tracecompass.incubator.scripting.core/src/org/eclipse/tracecompass/incubator/scripting/core/doc-files/scriptedDataProvider.js (diff)
The file was modified doc/org.eclipse.tracecompass.incubator.scripting.doc.user/doc/User-Guide.mediawiki (diff)
The file was modified scripting/org.eclipse.tracecompass.incubator.scripting.core/src/org/eclipse/tracecompass/incubator/scripting/core/doc-files/basicAnalysis.py (diff)
The file was modified scripting/org.eclipse.tracecompass.incubator.scripting.core.tests/testfiles/scripts/testAnalysis.js (diff)
The file was modified scripting/org.eclipse.tracecompass.incubator.scripting.core/src/org/eclipse/tracecompass/incubator/scripting/core/analysis/AnalysisScriptingModule.java (diff)
The file was modified scripting/org.eclipse.tracecompass.incubator.scripting.core/src/org/eclipse/tracecompass/incubator/scripting/core/doc-files/basicAnalysis.js (diff)