Changes

kernel: Fix few IoPerProcessDataProvider warnings

Fix some of the warnings ([1,2] below) in IoPerProcessDataProvider.

[1] "Non-externalized string literal; it should be followed by
//$NON-NLS-<n>$".

[2] "The nullness annotation is redundant with a default that applies to
this location".

Change-Id: I924ed1510c63b5d176628183d577aeb4bbacb786
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/201543
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

kernel: Fix an IoPerProcessDataProvider sonarlint

Fix this SonarLint (local IDE) warning in IoPerProcessDataProvider.

[1] "Use isEmpty() to check whether the collection is empty or not".

Change-Id: I5d20520b6ec126b589525abb1a10664611550b46
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/201544
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

kernel: Fix redundant nullness annotation warnings

Fix these warnings [1] below in SchedWS and IoByProcessView.

Fix the default Eclipse formatting where lightly applicable while there.

[1] "The nullness annotation is redundant with a default that applies to
this location".

Change-Id: I1ccf2698836fac12f2f989bb1942c614a7658ede
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/201545
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

multiview: Fix some warnings in AbstractTimeGraphMultiViewer

Fix some of the warnings ([1,2] below) in AbstractTimeGraphMultiViewer.

Also fix the SonarLint issue [3] while in there.

[1] "Non-externalized string literal; it should be followed by
//$NON-NLS-<n>$".

[2] "The nullness annotation is redundant with a default that applies to
this location".

[3] Remove this "String" constructor.

Change-Id: Iab957f5f84ed74eb075a105171c9afd65cf084ae
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/201546
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

releng: Use HTTPS for https://eclipse.py4j.org

Change-Id: I7605c87e6dd317c02040b82bfc8591cd82210c2f
Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/201560
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

callstack: Fix the FlameChartView file formatting

Fix the default Eclipse formatting for this whole file, except for its
NOSONAR line to preserve as is.

Change-Id: I373aaf6448183153809a982c42904fba60c0f0c8
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/201547
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Bug 581856: Remove the deprecated IElementResolver

Replace it with ICoreElementResolver use, as prescribed by the
deprecation notice.

Deprecated in org.eclipse.tracecompass commit 2d3d2f02cd, since v7.1.0.

This change accompanies the corresponding removal in o.e.tracecompass.

Change-Id: Ib6465e85b49b61b6d9b3e7c7bb19aa504bb7f645
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/201548
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

callstack: Fix non-externalized in FlameGraphView

Fix the few Eclipse warnings [1] below in FlameGraphView.

Fix the default Eclipse formatting while editing this file. For some of
the shorter comments, slightly amend them to keep their oneline-ness.

[1] "Non-externalized string literal; it should be followed by
//$NON-NLS-<n>$".

Change-Id: I257a647e4e1b7ddae4e89b1e874034e41827f211
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/201571
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Bug 581856: Remove the deprecated IFilterProperty

Replace it with CoreFilterProperty use, as prescribed by the deprecation
notice.

Deprecated in org.eclipse.tracecompass commit 2d3d2f02cd, since v7.1.0.

Reorganize the imports while doing these replacements, accordingly.

This change accompanies the corresponding removal in o.e.tracecompass.

Change-Id: I1a34c26fcc662b65ed26535e18da9c80f644aa4d
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/201572
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>