Changes

skeleton: update parent version

This is not necessary if a plugin (created using the skeleton script) is
built using Eclipse, but it is required when including the plugin in an
RCP and building it.

Change-Id: Ice5d9d3cdc613cbe2f27dd037a6349cc5bef98ce
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/195196
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

skeleton: Fix typos in related README files (RCP)

Change-Id: I2bc64b053fe643c82ce3bee316009b1fc93abd35
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/195367
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

skeleton: add base ID option

This allows users to specify a base ID to replace the usual
org.eclipse.tracecompass.incubator prefix. For example, this could be
used by a company called "ACME" to create plugins for their own
features. They would then use the "com.acme" base ID.

To test this:

1. cd ./skeleton
2. ./create_new_feature.py Defaults --dir ../tracetypes --copyright Acme
3. ./create_new_feature.py Acmes --dir ../tracetypes --copyright Acme \
    --base-id com.acme

Grepping for "org.eclipse.tracecompass.incubator" proves the absence of
it, since "com.acme" was used instead in the generated "Acmes" plugin
files. Only the annotation-equipped classpath files kept it, which is
expected.

As for the "Defaults" case above, which does not use the '--base-id'
option, regenerating an existing plugin gives the same result it would
have given before, as expected.

Loading the resulting new projects in Eclipse builds successfully, same
for the maven build from clean.

Change-Id: If8528e5f0282074565856509538e046a6bf7f8af
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/194973
Tested-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-by: Marco Miller <marco.miller@ericsson.com>

server: Make the EndpointConstants class final

Rather than adding a public constructor to it, which would fit less with
its current mandate. Fix the related sonarlint issue [1] below this way.

[1] Classes without "public" constructors should be "final" (java:S2974)

Change-Id: I8fc542454df7e3d872bfafdc68e56843f400cb27
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/195385
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>