Skip to content

Changes

Summary

  1. Fix some performance (FindBugs hint) using (details)
  2. Better usage of toArray() (details)
  3. Bug 404346: org.eclipse.swtbot.swt.finder depends on hamcrest 1.3 (details)
  4. Warning hunt + project metadata to force usage of FindBugs (details)
Commit 4e2af94f85c700d846a90512d4a42ae270d3468d by Mickael Istria
Fix some performance (FindBugs hint) using

* Integer.valueOf() instead of new Integer()
* Integer.parseInt(string) instead of new Integer(string).intValue()
* Integer.toString(int) instead of new Integer(int).toString()

Signed-off-by: Mickael Istria <mistria@redhat.com>
The file was modified org.eclipse.swt.examples/src/org/eclipse/swt/examples/javaviewer/JavaLineStyler.java
The file was modified org.eclipse.swt.examples/src/org/eclipse/swt/examples/fileviewer/FileViewer.java
The file was modified org.eclipse.swt.examples/src/org/eclipse/swt/examples/paint/PaintExample.java
The file was modified org.eclipse.swt.examples/src/org/eclipse/swt/examples/imageanalyzer/ImageAnalyzer.java
The file was modified org.eclipse.swt.examples/src/org/eclipse/swt/examples/addressbook/DataEntryDialog.java
The file was modified org.eclipse.swtbot.swt.finder/src/org/eclipse/swtbot/swt/finder/utils/StringUtils.java
The file was modified org.eclipse.swt.examples/src/org/eclipse/swt/examples/layoutexample/GridLayoutTab.java
The file was modified org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/Tab.java
The file was modified org.eclipse.swt.examples/src/org/eclipse/swt/examples/graphics/CountDownTab.java
The file was modified org.eclipse.swt.examples/src/org/eclipse/swt/examples/graphics/MazeTab.java
The file was modified org.eclipse.swt.examples/src/org/eclipse/swt/examples/layoutexample/FormLayoutTab.java
The file was modified org.eclipse.swt.examples/src/org/eclipse/swt/examples/paint/PaintSurface.java
The file was modified org.eclipse.swt.examples/src/org/eclipse/swt/examples/layoutexample/Tab.java
Commit bf8b22d058ea6ec86416f4255b8889021abf3bbf by Mickael Istria
Better usage of toArray()

Don't use empty arrays (findbugs hint)

Signed-off-by: Mickael Istria <mistria@redhat.com>
The file was modified org.eclipse.swtbot.swt.finder/src/org/eclipse/swtbot/swt/finder/keyboard/Keystrokes.java
The file was modified org.eclipse.swtbot.swt.finder/src/org/eclipse/swtbot/swt/finder/widgets/SWTBotTree.java
The file was modified org.eclipse.swtbot.swt.finder/src/org/eclipse/swtbot/swt/finder/widgets/SWTBotTreeItem.java
The file was modified org.eclipse.swtbot.swt.finder/src/org/eclipse/swtbot/swt/finder/keyboard/Keyboard.java
The file was modified org.eclipse.swtbot.swt.finder.test/src/org/eclipse/swtbot/swt/finder/keyboard/KeyboardLayoutGenerator.java
The file was modified org.eclipse.swtbot.swt.finder/src/org/eclipse/swtbot/swt/finder/SWTBotFactory.java
Commit 1950b0a5afe4bb757cf107bf0b11b36431b3595e by Mickael Istria
Bug 404346: org.eclipse.swtbot.swt.finder depends on hamcrest 1.3

Signed-off-by: Mickael Istria <mistria@redhat.com>
The file was modified org.eclipse.swtbot.swt.finder/META-INF/MANIFEST.MF
Commit 5c8821ef5acf6956a49b728d66060d224bc37505 by Mickael Istria
Warning hunt + project metadata to force usage of FindBugs

Signed-off-by: Mickael Istria <mistria@redhat.com>
The file was addeddevtools/target-platforms/juno/.settings/org.eclipse.m2e.core.prefs
The file was addedorg.eclipse.swtbot.swt.finder.test.keyboards/src/org/eclipse/swtbot/finder/keyboard/empty.keyboard
The file was addedtarget-platforms/.project
The file was modified org.eclipse.swtbot.swt.finder/src/org/eclipse/swtbot/swt/finder/matchers/AbstractMatcher.java
The file was modified org.eclipse.swtbot.eclipse.finder.test/src/org/eclipse/swtbot/eclipse/finder/test/ui/data/internal/SWTBotTestData.java
The file was modified org.eclipse.swtbot.eclipse.gef.finder/src/org/eclipse/swtbot/eclipse/gef/finder/widgets/SWTBotGefContextMenu.java
The file was addedorg.eclipse.swtbot.eclipse.finder/src/org/eclipse/swtbot/eclipse/finder/SWTBotEclipseFinderPlugin.java
The file was modified org.eclipse.swtbot.eclipse.gef.finder/src/org/eclipse/swtbot/eclipse/gef/finder/widgets/SWTBotGefEditPart.java
The file was addedorg.eclipse.swtbot.generator/.settings/edu.umd.cs.findbugs.core.prefs
The file was modified org.eclipse.swtbot.swt.finder/.project
The file was addeddevtools/target-platforms/indigo/.project
The file was addedorg.eclipse.swtbot.eclipse.gef.finder/.settings/edu.umd.cs.findbugs.core.prefs
The file was modified org.eclipse.swtbot.swt.finder/src/org/eclipse/swtbot/swt/finder/widgets/AbstractSWTBot.java
The file was modified org.eclipse.swtbot.generator/.project
The file was modified org.eclipse.swtbot.generator/src/org/eclipse/swtbot/generator/framework/rules/simple/CheckboxClickedRule.java
The file was modified org.eclipse.swtbot.generator/src/org/eclipse/swtbot/generator/framework/rules/simple/RadioButtonClickedRule.java
The file was modified org.eclipse.swtbot.eclipse.gef.finder/.project
The file was modified org.eclipse.swtbot.generator/src/org/eclipse/swtbot/generator/framework/rules/simple/PushButtonClickedRule.java
The file was addedexamples/org.eclipse.ui.forms.examples/examples.jar
The file was modified org.eclipse.swtbot.swt.finder/src/org/eclipse/swtbot/swt/finder/matchers/InGroup.java
The file was modified org.eclipse.swtbot.swt.finder/src/org/eclipse/swtbot/swt/finder/resolvers/CompositeResolver.java
The file was addedorg.eclipse.swtbot.eclipse.finder/.settings/org.eclipse.m2e.core.prefs
The file was addedorg.eclipse.swtbot.releng/.project
The file was modified org.eclipse.swt.examples/src/org/eclipse/swt/examples/addressbook/AddressBook.java
The file was addedorg.eclipse.swtbot.swt.finder/.settings/edu.umd.cs.findbugs.core.prefs
The file was modified org.eclipse.swtbot.generator/src/org/eclipse/swtbot/generator/framework/rules/simple/AbstractTreeGenerationRule.java
The file was addedorg.eclipse.swtbot.swt.finder.test.keyboards/.settings/org.eclipse.jdt.core.prefs
The file was addeddevtools/target-platforms/indigo/.settings/org.eclipse.m2e.core.prefs
The file was addedorg.eclipse.swtbot.swt.finder/.settings/org.eclipse.m2e.core.prefs
The file was modified org.eclipse.swt.examples/.project
The file was modified org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/CTabFolderTab.java
The file was modified org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/CoolBarTab.java
The file was modified org.eclipse.swtbot.eclipse.finder/src/org/eclipse/swtbot/eclipse/finder/DefaultWorkbench.java
The file was addedorg.eclipse.swt.examples/.settings/edu.umd.cs.findbugs.core.prefs
The file was modified org.eclipse.swtbot.swt.finder/src/org/eclipse/swtbot/swt/finder/widgets/SWTBotMenu.java
The file was modified org.eclipse.swtbot.eclipse.finder.test/.project
The file was addedorg.eclipse.swtbot.eclipse.finder.test/.settings/org.eclipse.m2e.core.prefs
The file was addeddevtools/target-platforms/juno/.project
The file was addedorg.eclipse.swtbot.eclipse.finder.test/.settings/edu.umd.cs.findbugs.core.prefs
The file was addedorg.eclipse.swtbot.swt.finder.test/.settings/org.eclipse.m2e.core.prefs