Skip to content
Success

Changes

Summary

  1. Update maven master to 3.12.7 (details)
  2. FormBasedLogin: forwarding to login page does not always work (details)
  3. FormBasedLogin: redirect to url with special characters does not work (details)
  4. ErrorHandler: fix brackets (details)
  5. ScoutJS: Add support for batch LookupCalls in SmartColumns (details)
  6. RestApplication: reduce default log output (details)
  7. Fix TableControlSpec (details)
  8. Improve processed text when copying rows from table (details)
Commit 74493f8c484831879f86892fb74f03b95fc12338 by Arthur van Dorp
Update maven master to 3.12.7
The file was modified org.eclipse.scout.rt/pom.xml
Commit 59adc93ff6e55e09ca971f71360aadb1fb2c1533 by Claudio Guglielmo
FormBasedLogin: forwarding to login page does not always work

If the requested url contains subfolders, the forwarding to the
login page does not work.
Reason: the login resources (login.js etc.) are located in the root
folder, but if a sub resource returns the login.html, the login
resources cannot be loaded because they are addressed relatively
(e.g. /subfolder/login.js).

Fixed by remembering the original path on the http session and
redirecting after successful login.

Note: normally (if page reloading is sufficient), no session will be
created during the login process. The new redirect feature requires
a session to store the redirect url, but the session is only used
temporarily and will be invalidated after a successful login. So
compared to today, the existing regular login process has not changed
and behaves as usual, only if the new redirect process is activated
a temporary session is created and the regular session is created a
little bit earlier in the process (right after invalidation).

266091

Change-Id: Ia2302a8fadca00f5e0d332928166f0d9d4f6e509
Reviewed-on: https://git.eclipse.org/r/c/scout/org.eclipse.scout.rt/+/165806
Tested-by: Scout Bot <scout-bot@eclipse.org>
Tested-by: CI Bot
Reviewed-by: Claudio Guglielmo <claudio.guglielmo@bsiag.com>
The file was modified org.eclipse.scout.rt.server.commons/src/main/java/org/eclipse/scout/rt/server/commons/authentication/FormBasedAccessController.java
The file was modified org.eclipse.scout.rt.server.commons/src/main/java/org/eclipse/scout/rt/server/commons/authentication/ServletFilterHelper.java
The file was modified org.eclipse.scout.rt.server.commons/src/main/java/org/eclipse/scout/rt/server/commons/authentication/TrivialAccessController.java
Commit 8a127744ca1d4b90b208c7c3080165ede8d21965 by Claudio Guglielmo
FormBasedLogin: redirect to url with special characters does not work

If the url contains special characters the redirecting may fail, e.g.
with Safari on os x.

Example:
http://localhost:8082/help/Einführung.htm
will be redirected to
http://localhost:8082/help/Einf%FChrung.htm

%FC is the char ü with ISO 8859.

To make it work it has to be encoded with UTF-8. This needs to be done
manually because sendRedirect does not encode. Each part of the
url needs to be encoded separately, so that / won't be changed.

Additionally, the query string was missing after redirecting ->
it is now saved along with the path info.

266091
The file was modified org.eclipse.scout.rt.server.commons/src/main/java/org/eclipse/scout/rt/server/commons/authentication/ServletFilterHelper.java
Commit 354174141c8efbbf8d8a15a10ba7a96c58f736e2 by Beat Schwarzentrub
ErrorHandler: fix brackets
The file was modified eclipse-scout-core/src/ErrorHandler.js
Commit 771ed8154af0f9adbecdfd9f6ba8f2d8eb7b4c62 by Beat Schwarzentrub
ScoutJS: Add support for batch LookupCalls in SmartColumns

- only affects ScoutJS (Scout Classic already supports batch lookups)

273831

Change-Id: Icba593d6e6df3804cf5e3bd72661795b0feb52f3
Reviewed-on: https://git.eclipse.org/r/c/scout/org.eclipse.scout.rt/+/167826
Tested-by: Scout Bot <scout-bot@eclipse.org>
Reviewed-by: Beat Schwarzentrub <bsh@bsiag.com>
The file was modified eclipse-scout-core/src/lookup/QueryBy.js
The file was modified eclipse-scout-core/src/table/columns/SmartColumn.js
The file was modified eclipse-scout-core/test/table/columns/SmartColumnSpec.js
The file was modified eclipse-scout-core/src/lookup/LookupCall.js
Commit c9c2dde6c7ed5f45084248873ebfcdf2018faa80 by Beat Schwarzentrub
RestApplication: reduce default log output

Change-Id: I3063e221635528421aa65c4f414e74c295a66b0f
Reviewed-on:
https://git.eclipse.org/r/c/scout/org.eclipse.scout.rt/+/167886
Tested-by: Paolo Bazzi <paolo.bazzi@bsi-software.com>
Tested-by: Scout Bot <scout-bot@eclipse.org>
Reviewed-by: Paolo Bazzi <paolo.bazzi@bsi-software.com>
(cherry picked from commit c039ff98a929a34869464c660073bd290c04409e)
The file was modified org.eclipse.scout.rt.rest/src/main/java/org/eclipse/scout/rt/rest/RestApplication.java
Commit 37a36721369af7a88311a156e360250d54c8df00 by Beat Schwarzentrub
Fix TableControlSpec

Immediately end the closing animation when deselecting the table
control, to make the toBeHidden() assertion more reliable on slow
machines.

(Cherry-picked from 9.0.x: 46fe10a9b56b3e596835d0aa86f720f3c8298818)

Change-Id: I6e201deb7b6d0a7c512624e936abbb6c863d462a
Reviewed-on: https://git.eclipse.org/r/c/scout/org.eclipse.scout.rt/+/168008
Tested-by: Beat Schwarzentrub <bsh@bsiag.com>
Reviewed-by: Beat Schwarzentrub <bsh@bsiag.com>
The file was modified eclipse-scout-core/test/table/controls/TableControlSpec.js
Commit 0c45abec12bc1bb1b5e65b7786b3b90dd3d73a85 by Beat Schwarzentrub
Improve processed text when copying rows from table

For each cell, the value is splitted into lines, tabs replaced by blanks
to keep structure, trimmed, empty lines removed and joined separated
with single newlines.

242101

Change-Id: I7bfff4915a99a3241c582645bd28696a009ae325
Reviewed-on: https://git.eclipse.org/r/c/scout/org.eclipse.scout.rt/+/167986
Reviewed-by: Beat Schwarzentrub <bsh@bsiag.com>
Tested-by: Scout Bot <scout-bot@eclipse.org>
The file was modified org.eclipse.scout.rt.client/src/main/java/org/eclipse/scout/rt/client/ui/basic/table/AbstractTable.java
The file was modified org.eclipse.scout.rt.client.test/src/test/java/org/eclipse/scout/rt/client/ui/basic/table/TableTest.java