Skip to content

Changes

Summary

  1. Prepare 4.5.2-SNAPSHOT builds (details)
  2. Don't flag a packfile invalid if opening existing file failed (details)
  3. Only mark packfile invalid if exception signals permanent problem (details)
Commit 11a12ceb0be1bf13e2e6d5de2368688a58f9400c by Matthias Sohn
Prepare 4.5.2-SNAPSHOT builds

Change-Id: I8485de1f3f63dc9ec445b8fb08093ca144aedc59
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
The file was modified org.eclipse.jgit.test/pom.xml
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.feature/feature.xml
The file was modified org.eclipse.jgit.lfs/pom.xml
The file was modified org.eclipse.jgit.lfs.server/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.pgm.source.feature/pom.xml
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.pgm.feature/pom.xml
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.lfs.feature/feature.xml
The file was modified org.eclipse.jgit.http.test/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.junit.http/pom.xml
The file was modified org.eclipse.jgit.archive/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.lfs.test/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.repository/pom.xml
The file was modified org.eclipse.jgit.pgm/META-INF/SOURCE-MANIFEST.MF
The file was modified org.eclipse.jgit.test/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.archive/META-INF/SOURCE-MANIFEST.MF
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.http.apache.feature/pom.xml
The file was modified org.eclipse.jgit.ant/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.archive/pom.xml
The file was modified org.eclipse.jgit.pgm/pom.xml
The file was modified org.eclipse.jgit.http.server/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.lfs.feature/pom.xml
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.source.feature/pom.xml
The file was modified org.eclipse.jgit.pgm.test/pom.xml
The file was modified org.eclipse.jgit.ant.test/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.pgm.source.feature/feature.xml
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.source.feature/feature.xml
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.feature/pom.xml
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.junit.feature/feature.xml
The file was modified org.eclipse.jgit.http.apache/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.http.test/pom.xml
The file was modified org.eclipse.jgit.junit/pom.xml
The file was modified org.eclipse.jgit.packaging/pom.xml
The file was modified org.eclipse.jgit.lfs.server.test/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.junit.feature/pom.xml
The file was modified org.eclipse.jgit.junit/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.junit.http/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.http.server/pom.xml
The file was modified org.eclipse.jgit.lfs.test/pom.xml
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.http.apache.feature/feature.xml
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.target/pom.xml
The file was modified org.eclipse.jgit.ui/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.lfs/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.pgm.feature/feature.xml
The file was modified org.eclipse.jgit.lfs.server.test/pom.xml
The file was modified org.eclipse.jgit.ant.test/pom.xml
The file was modified org.eclipse.jgit.lfs.server/pom.xml
The file was modified org.eclipse.jgit/pom.xml
The file was modified org.eclipse.jgit/META-INF/SOURCE-MANIFEST.MF
The file was modified org.eclipse.jgit.pgm.test/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.ui/pom.xml
The file was modified org.eclipse.jgit.http.apache/pom.xml
The file was modified pom.xml
The file was modified org.eclipse.jgit.packaging/org.eclipse.jgit.target/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.pgm/META-INF/MANIFEST.MF
The file was modified org.eclipse.jgit.ant/pom.xml
Commit 363a3657b133ea4668bd832410eff67cfdb7dfd1 by Matthias Sohn
Don't flag a packfile invalid if opening existing file failed

A packfile random file open operation may fail with a
FileNotFoundException even if the file exists, possibly
for the temporary lack of resources.

Instead of managing the FileNotFoundException as any generic
IOException it is best to rethrow the exception but prevent
the packfile for being flagged as invalid until it is actually
opened and read successfully or unsuccessfully.

Bug: 514170
Change-Id: Ie37edba2df77052bceafc0b314fd1d487544bf35
Signed-off-by: Luca Milanesio <luca.milanesio@gmail.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
The file was modified org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/PackFile.java
Commit aaf3c5154ea3b8a367266a7be7100ad7386a84b3 by Matthias Sohn
Only mark packfile invalid if exception signals permanent problem

Add NoPackSignatureException and UnsupportedPackVersionException to
explicitly mark permanent unrecoverable problems with a pack

Assume problem with a pack is permanent only if we are sure the
exception signals a non-transient problem we can't recover from:
- AccessDeniedException: we lack permissions
- CorruptObjectException: we detected corruption
- EOFException: file ended unexpectedly
- NoPackSignatureException: pack has no pack signature
- NoSuchFileException: file has gone missing
- PackMismatchException: pack no longer matches its index
- UnpackException: unpacking failed
- UnsupportedPackIndexVersionException: unsupported pack index version
- UnsupportedPackVersionException: unsupported pack version

Do not attempt to handle Errors since they are thrown for serious
problems applications should not try to recover from.

Change-Id: I2c416ce2b0e23255c4fb03a3f9a0ee237f7a484a
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
The file was modified org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/PackIndex.java
The file was modified org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/PackFile.java
The file was addedorg.eclipse.jgit/src/org/eclipse/jgit/errors/UnsupportedPackVersionException.java
The file was addedorg.eclipse.jgit/.settings/.api_filters
The file was addedorg.eclipse.jgit/src/org/eclipse/jgit/errors/NoPackSignatureException.java
The file was addedorg.eclipse.jgit/src/org/eclipse/jgit/errors/UnsupportedPackIndexVersionException.java