Skip to content

Changes

Summary

  1. ManifestParser: Throw exception if remote does not have fetch attribute (details)
  2. Cleanup and test trailing slash handling in ManifestParser (details)
Commit 84d855cda7fc3f061778ea54b4f7ea569a75d7c3 by Matthias Sohn
ManifestParser: Throw exception if remote does not have fetch attribute

In the repo manifest documentation [1] the fetch attribute is marked
as "#REQUIRED".

If the fetch attribute is not specified, this would previously result in
NullPointerException. Throw a SAXException instead.

[1] https://gerrit.googlesource.com/git-repo/+/master/docs/manifest-format.txt

Change-Id: Ib8ed8cee6074fe6bf8f9ac6fc7a1664a547d2d49
Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
The file was modified org.eclipse.jgit/resources/org/eclipse/jgit/gitrepo/internal/RepoText.properties
The file was modified org.eclipse.jgit/src/org/eclipse/jgit/gitrepo/ManifestParser.java
The file was modified org.eclipse.jgit/src/org/eclipse/jgit/gitrepo/internal/RepoText.java
The file was modified org.eclipse.jgit.test/tst/org/eclipse/jgit/gitrepo/ManifestParserTest.java
Commit f17ec3928c45d7f5170e92b4e0e1f7390de5fff2 by Matthias Sohn
Cleanup and test trailing slash handling in ManifestParser

This is a workaround for
https://bugs.openjdk.java.net/browse/JDK-4666701.

Change-Id: Idd04657e8d95a841d72230f8881b6b899daadbc2
Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
The file was modified org.eclipse.jgit.test/tst/org/eclipse/jgit/gitrepo/RepoCommandTest.java
The file was modified org.eclipse.jgit.test/tst/org/eclipse/jgit/gitrepo/ManifestParserTest.java
The file was modified org.eclipse.jgit/src/org/eclipse/jgit/gitrepo/ManifestParser.java