Skip to content
Success

Changes

Summary

  1. Remove PreDestroy annotation in MongoDbBasedDao. (details)
  2. Fix table formatting in HTTP adapter user guide. (details)
  3. Remove trailing newline in text block strings. (details)
  4. [#2660] Prevent "already creating client for key" errors. (details)
  5. Rename ClientFactory#clearState() to onDisconnect(). (details)
  6. Refactor HonoKafkaConsumer topic subscription update. (details)
  7. Replace Non-ASCII characters. (details)
  8. [#3361] Change HTTP adapter idleTimeout default to 75s. (details)
  9. Apply javadoc fixes and improvements. (details)
  10. Fix documentation regarding device registry HTTP port. (details)
  11. Enable running the native-images-tests workflow manually. (details)
  12. Fix layout issues in device registry management API docs. (details)
  13. [#3372] Allow builing of docker images for windows (details)
  14. [#3377] Fix uncaught exception trying to close endpoint. (details)
  15. [#3366] Fix of non-closing future in HTTP adapter (details)
  16. Apply minor improvements regarding new ResponseReadyTracker. (details)
  17. [#3381] Fix documentation search function. (details)
  18. [#3333] Use build-in collector in Jaeger All-In-One, instead of separate collector component (details)
  19. Refactor TracingHelper.logError methods. (details)
  20. [#2809] Improve handling of MongoDB client errors on shutdown. (details)
  21. Adapt HTTP error logging. (details)
  22. Rename notification 'enabled' field/getter. (details)
  23. [#3360] Create native executable command line client (details)
Commit 8ab4af8e66363d771f16839cc5df8071b8d988e3 by Carsten Lohmann
Remove PreDestroy annotation in MongoDbBasedDao.

The PreDestroy method was not actually getting invoked in
the Hono Mongo DB device registry component. There, the
vert.x mongoClient instance should get closed automatically
when undeploying the Verticle it is used in (via the close
hook added by the vert.x mongoClient).

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified services/device-registry-mongodb/src/main/java/org/eclipse/hono/deviceregistry/mongodb/model/MongoDbBasedDao.java (diff)
Commit 79dfa0a94565f9878791b7ff6aebd3a1cc7bd98d by Carsten Lohmann
Fix table formatting in HTTP adapter user guide.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified site/documentation/content/user-guide/http-adapter.md (diff)
Commit b9810c82bffc8b7727edf805ff6e1aa700c8b6fc by Carsten Lohmann
Remove trailing newline in text block strings.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified clients/kafka-common/src/main/java/org/eclipse/hono/client/kafka/consumer/HonoKafkaConsumer.java (diff)
The file was modified service-base/src/main/java/org/eclipse/hono/service/AbstractServiceApplication.java (diff)
The file was modified services/command-router/src/main/java/org/eclipse/hono/commandrouter/impl/kafka/KafkaBasedCommandConsumerFactoryImpl.java (diff)
The file was modified tests/src/test/java/org/eclipse/hono/tests/client/HonoKafkaConsumerIT.java (diff)
The file was modified service-base/src/main/java/org/eclipse/hono/service/auth/JjwtBasedAuthTokenValidator.java (diff)
The file was modified clients/kafka-common/src/main/java/org/eclipse/hono/client/kafka/KafkaClientFactory.java (diff)
Commit 615542264008dbc7e488db5272aeed329885921c by Carsten Lohmann
[#2660] Prevent "already creating client for key" errors.

Concurrent getOrCreateClient() invocations are now completed
along with the initial creation request.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified clients/client-common/src/main/java/org/eclipse/hono/client/util/ClientFactory.java (diff)
The file was modified clients/client-common/src/main/java/org/eclipse/hono/client/util/CachingClientFactory.java (diff)
The file was modified clients/client-common/src/test/java/org/eclipse/hono/client/util/CachingClientFactoryTest.java (diff)
Commit b302b29b79a93c00e7e1741ba4a415d56ba1e7dc by Carsten Lohmann
Rename ClientFactory#clearState() to onDisconnect().

Making it clearer that pending requests are failed
with a corresponding "no connection to service"
exception.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified clients/notification-amqp/src/main/java/org/eclipse/hono/client/notification/amqp/ProtonBasedNotificationReceiver.java (diff)
The file was modified services/command-router/src/main/java/org/eclipse/hono/commandrouter/impl/amqp/ProtonBasedCommandConsumerFactoryImpl.java (diff)
The file was modified clients/amqp-common/src/main/java/org/eclipse/hono/client/amqp/SenderCachingServiceClient.java (diff)
The file was modified clients/client-common/src/test/java/org/eclipse/hono/client/util/CachingClientFactoryTest.java (diff)
The file was modified clients/client-common/src/main/java/org/eclipse/hono/client/util/ClientFactory.java (diff)
The file was modified clients/device-amqp/src/main/java/org/eclipse/hono/client/device/amqp/impl/ProtonBasedAmqpAdapterClient.java (diff)
The file was modified clients/amqp-common/src/main/java/org/eclipse/hono/client/amqp/AbstractRequestResponseServiceClient.java (diff)
The file was modified clients/client-common/src/main/java/org/eclipse/hono/client/util/CachingClientFactory.java (diff)
Commit 6d9cf44b1ab7f01a39816377f6365020caeea0a4 by Carsten Lohmann
Refactor HonoKafkaConsumer topic subscription update.

Decoupling the used logic from the one used for the initial topic subscription.
Also letting the "subscribe" and "partitionsFor" invocations be invoked directly
one after the other.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was addedtests/src/test/java/org/eclipse/hono/tests/client/AsyncHandlingAutoCommitKafkaConsumerIT.java
The file was modified tests/src/test/java/org/eclipse/hono/tests/client/HonoKafkaConsumerIT.java (diff)
The file was modified clients/kafka-common/src/main/java/org/eclipse/hono/client/kafka/consumer/AsyncHandlingAutoCommitKafkaConsumer.java (diff)
The file was modified clients/kafka-common/src/main/java/org/eclipse/hono/client/kafka/consumer/HonoKafkaConsumer.java (diff)
Commit 71343c924459f63178cee93220e61e0620c315a3 by Carsten Lohmann
Replace Non-ASCII characters.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified services/device-registry-mongodb/src/main/java/org/eclipse/hono/deviceregistry/mongodb/model/MongoDbBasedTenantDao.java (diff)
The file was modified services/device-registry-base/src/main/java/org/eclipse/hono/deviceregistry/metrics/DeviceRegistryMetricsAdapter.java (diff)
Commit 5ed784f4e2043f57af956aeac75aaf1b6d01e9f6 by Carsten Lohmann
[#3361] Change HTTP adapter idleTimeout default to 75s.

Value should be higher than the tenant-configuration
"max-ttd" default of 60s.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified site/documentation/content/admin-guide/http-adapter-config.md (diff)
The file was modified service-base/src/test/java/org/eclipse/hono/service/http/HttpServiceConfigOptionsTest.java (diff)
The file was modified service-base/src/main/java/org/eclipse/hono/service/http/HttpServiceConfigOptions.java (diff)
The file was modified adapters/http-base/src/test/java/org/eclipse/hono/adapter/http/AbstractVertxBasedHttpProtocolAdapterTest.java (diff)
The file was modified adapters/http-base/src/main/java/org/eclipse/hono/adapter/http/HttpProtocolAdapterOptions.java (diff)
The file was modified site/documentation/content/user-guide/http-adapter.md (diff)
The file was modified adapters/http-base/src/main/java/org/eclipse/hono/adapter/http/HttpProtocolAdapterProperties.java (diff)
The file was modified service-base/src/test/resources/http-service-config-options.yaml (diff)
The file was modified adapters/http-base/src/main/java/org/eclipse/hono/adapter/http/AbstractVertxBasedHttpProtocolAdapter.java (diff)
The file was modified service-base/src/main/java/org/eclipse/hono/service/http/HttpServiceConfigProperties.java (diff)
Commit a8b3f5e7c8f903bd450e42de721d5c39db639223 by Carsten Lohmann
Apply javadoc fixes and improvements.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified services/device-registry-base/src/main/java/org/eclipse/hono/service/management/credentials/PskSecret.java (diff)
The file was modified services/device-registry-base/src/test/java/org/eclipse/hono/deviceregistry/util/Assertions.java (diff)
The file was modified adapter-base/src/main/java/org/eclipse/hono/adapter/monitoring/ConnectionEventProducer.java (diff)
The file was modified service-base/src/main/java/org/eclipse/hono/service/HealthCheckProvider.java (diff)
The file was modified service-base/src/main/java/org/eclipse/hono/service/SmallRyeHealthCheckServer.java (diff)
The file was modified adapter-base/src/main/java/org/eclipse/hono/adapter/AbstractProtocolAdapterBase.java (diff)
The file was modified adapters/lora/src/main/java/org/eclipse/hono/adapter/lora/providers/LoraUtils.java (diff)
The file was modified services/device-registry-base/src/main/java/org/eclipse/hono/service/management/BaseDto.java (diff)
The file was modified service-base/src/main/java/org/eclipse/hono/service/HealthCheckServer.java (diff)
The file was modified service-base/src/main/java/org/eclipse/hono/service/NoopHealthCheckServer.java (diff)
The file was modified adapters/http-base/src/main/java/org/eclipse/hono/adapter/http/impl/VertxBasedHttpProtocolAdapter.java (diff)
Commit 92a7f24b7e37427d62b1a2df6881099479054fb0 by Carsten Lohmann
Fix documentation regarding device registry HTTP port.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified site/documentation/content/admin-guide/jdbc-device-registry-config.md (diff)
The file was modified site/documentation/content/admin-guide/mongodb-device-registry-config.md (diff)
Commit 3f7376a37275e0508886d32dd2e90066bad5c338 by Carsten Lohmann
Enable running the native-images-tests workflow manually.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified .github/workflows/native-images-tests.yml (diff)
Commit 60b2dca2174e723db982e4c5fd90869fc5c9b3de by Carsten Lohmann
Fix layout issues in device registry management API docs.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified site/documentation/static/css/hono.css (diff)
Commit 337173cd2e5165b54ce3abe3b069cd3552083eb1 by Carsten Lohmann
[#3372] Allow builing of docker images for windows

before this change the run shell script hasn't had run permissions

Signed-off-by: Marinov Avgustin <Avgustin.Marinov@bosch.io
The file was modified adapters/parent/pom.xml (diff)
The file was modified services/parent/pom.xml (diff)
Commit 3c0ef9b0bf68f4ad849cb8ca9bb9e9856123c11d by Carsten Lohmann
[#3377] Fix uncaught exception trying to close endpoint.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified adapters/mqtt-base/src/main/java/org/eclipse/hono/adapter/mqtt/AbstractVertxBasedMqttProtocolAdapter.java (diff)
Commit 66edfac312aec164a4122efbff19b56e3e1fb600 by Carsten Lohmann
[#3366] Fix of non-closing future in HTTP adapter

Refactoring of HTTP adapter
- single place command consumer close
- single method & class handling waiting for command
Fix for non terminating duUploadMessage pipeline

Signed-off-by: Marinov Avgustin <Avgustin.Marinov@bosch.io
The file was modified adapters/http-base/src/test/java/org/eclipse/hono/adapter/http/impl/VertxBasedHttpProtocolAdapterTest.java (diff)
The file was modified adapters/http-base/src/main/java/org/eclipse/hono/adapter/http/AbstractVertxBasedHttpProtocolAdapter.java (diff)
Commit 3a77a4b063fdfe1733f535f0c6f22b64a7962046 by Carsten Lohmann
Apply minor improvements regarding new ResponseReadyTracker.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified adapters/http-base/src/main/java/org/eclipse/hono/adapter/http/AbstractVertxBasedHttpProtocolAdapter.java (diff)
The file was modified adapters/http-base/src/test/java/org/eclipse/hono/adapter/http/impl/VertxBasedHttpProtocolAdapterTest.java (diff)
Commit c4779ed421bf6cdae4b38e0a913d5f2520fbc5d5 by Carsten Lohmann
[#3381] Fix documentation search function.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified site/documentation/config.toml (diff)
Commit ed30a4b95cc056c01c359685ed1789878a3a5d8e by Carsten Lohmann
[#3333] Use build-in collector in Jaeger All-In-One, instead of separate collector component

Signed-off-by: Kristiyan Duba <kristiyan.duba@bosch.io>
The file was removedtests/src/test/resources/otel-collector/otel-collector-config.yaml
The file was modified bom/pom.xml (diff)
The file was modified tests/pom.xml (diff)
Commit 07b161ae36722f1508896954bfc885f06a2dd6c4 by Carsten Lohmann
Refactor TracingHelper.logError methods.

Moving 'skipUnexpectedErrorCheck' parameter to the
method with both 'message' and 'error' parameters.
Making null checks more consistent.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified core/src/main/java/org/eclipse/hono/tracing/TracingHelper.java (diff)
The file was modified service-base/src/main/java/org/eclipse/hono/service/http/DefaultFailureHandler.java (diff)
Commit 320e00438e84fac0aa764b93b58fba35450efb0c by Carsten Lohmann
[#2809] Improve handling of MongoDB client errors on shutdown.

Returning status 503 instead of 500 for an IllegalStateException
thrown because the session pool was already closed. Also
skipping unwanted log output in this case.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified services/device-registry-mongodb/src/main/java/org/eclipse/hono/deviceregistry/mongodb/model/MongoDbBasedCredentialsDao.java (diff)
The file was modified services/device-registry-mongodb/src/test/java/org/eclipse/hono/deviceregistry/mongodb/model/MongoDbBasedDeviceDaoTest.java (diff)
The file was modified services/device-registry-mongodb/src/main/java/org/eclipse/hono/deviceregistry/mongodb/model/MongoDbBasedDao.java (diff)
The file was modified services/device-registry-mongodb/src/test/java/org/eclipse/hono/deviceregistry/mongodb/model/MongoDbBasedCredentialsDaoTest.java (diff)
The file was modified services/device-registry-mongodb/src/test/java/org/eclipse/hono/deviceregistry/mongodb/model/MongoDbBasedTenantDaoTest.java (diff)
The file was modified services/device-registry-mongodb/src/main/java/org/eclipse/hono/deviceregistry/mongodb/model/MongoDbBasedDeviceDao.java (diff)
The file was modified services/device-registry-mongodb/src/main/java/org/eclipse/hono/deviceregistry/mongodb/app/DaoProducer.java (diff)
The file was modified services/device-registry-mongodb/src/main/java/org/eclipse/hono/deviceregistry/mongodb/model/MongoDbBasedTenantDao.java (diff)
The file was modified services/device-registry-mongodb/src/test/java/org/eclipse/hono/deviceregistry/mongodb/service/MongoDbTestUtils.java (diff)
Commit 4a49118c4e6dccb63af6d52634797140f078bf60 by Carsten Lohmann
Adapt HTTP error logging.

Request body isn't being logged anymore and inclusion
of stacktrace of a client error exception is omitted
(usually not needed, e.g. AbstractHttpEndpoint already
logs it).

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified service-base/src/main/java/org/eclipse/hono/service/http/DefaultFailureHandler.java (diff)
Commit bba79104d419c4a83c9725b10f49c37f163b9e79 by Carsten Lohmann
Rename notification 'enabled' field/getter.

Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
The file was modified services/device-registry-base/src/test/java/org/eclipse/hono/deviceregistry/service/device/AbstractDeviceManagementServiceTest.java (diff)
The file was modified clients/registry-amqp/src/main/java/org/eclipse/hono/client/registry/amqp/ProtonBasedTenantClient.java (diff)
The file was modified adapters/amqp/src/main/java/org/eclipse/hono/adapter/amqp/VertxBasedAmqpProtocolAdapter.java (diff)
The file was modified clients/notification/src/test/java/org/eclipse/hono/notification/deviceregistry/DeviceChangeNotificationTest.java (diff)
The file was modified services/device-registry-base/src/test/java/org/eclipse/hono/deviceregistry/service/tenant/AbstractTenantManagementServiceTest.java (diff)
The file was modified services/command-router/src/main/java/org/eclipse/hono/commandrouter/impl/kafka/KafkaBasedCommandConsumerFactoryImpl.java (diff)
The file was modified adapters/mqtt-base/src/main/java/org/eclipse/hono/adapter/mqtt/AbstractVertxBasedMqttProtocolAdapter.java (diff)
The file was modified clients/registry-amqp/src/main/java/org/eclipse/hono/client/registry/amqp/ProtonBasedCredentialsClient.java (diff)
The file was modified clients/notification/src/main/java/org/eclipse/hono/notification/deviceregistry/DeviceChangeNotification.java (diff)
The file was modified clients/notification/src/main/java/org/eclipse/hono/notification/deviceregistry/TenantChangeNotification.java (diff)
The file was modified clients/notification/src/test/java/org/eclipse/hono/notification/deviceregistry/TenantChangeNotificationTest.java (diff)
Commit 0dfa63ca23147782a0f337a32b75d98768cff117 by Kai Hudalla
[#3360] Create native executable command line client

The build jobs have been changed to consistently use the
eclipse/hono-builder container image for building Hono. This image
contains specific versions of Maven, the GraalVM SDK with the
native-image compiler plugin and the UPX tool for compressing binary
artifacts.

The release build job has been extended with an additional invocation
of mvn clean install used to build the native executable of the CLI.

The native executable needs to be built in a separate run because in the
first build the JAR file artifacts are being signed by the Eclipse JAR
signer service which results in signature errors during the native
executable build.

Signed-off-by: Kai Hudalla <kai.hudalla@bosch.io>
The file was addedjenkins/Hono-Native-Pipeline.groovy
The file was modified cli/pom.xml (diff)
The file was addedjenkins/Failing-Pipeline.groovy
The file was addedbuilder/HonoBuilder.dockerfile
The file was addedjenkins/HonoBuilderPod.yaml