Skip to content

Changes

Summary

  1. Fix an issue with the compatibility with Java 7 (details)
  2. Fix reference widget actions to be executed in the editing domain (details)
  3. Fix radio group modification. (details)
  4. Add missing Javadoc to avoid CheckStyle error (details)
  5. Add support for null values in combos (details)
Commit f22dd95c4839829646ddb85edae1608e014907c2 by Stephane Begaudeau
Fix an issue with the compatibility with Java 7

Change-Id: Ib871d05080e30330f5082c0e2a38919b371ba92e
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
The file was modified plugins/org.eclipse.eef.ide.ui/src/org/eclipse/eef/ide/ui/internal/widgets/quickfix/EEFValidationMessagesTableContentProvider.java
The file was modified plugins/org.eclipse.eef.ide.ui/src/org/eclipse/eef/ide/ui/internal/widgets/quickfix/EEFQuickFixTableContentProvider.java
Commit a3ac4fb069d6f4d5cd9d5a7144969d0ce6f90e69 by Stephane Begaudeau
Fix reference widget actions to be executed in the editing domain
adapter.

Change-Id: I313ded48ac668ceb950a73647e4d5be33ef8cff6
Signed-off-by: Mélanie Bats <melanie.bats@obeo.fr>
The file was modified plugins/org.eclipse.eef.core/src/org/eclipse/eef/core/internal/controllers/EEFReferenceController.java
Commit 34142ee60d2a217379b890f8a1243ead6455c479 by Stephane Begaudeau
Fix radio group modification.

Add selection listener on buttons instead of the group.

Change-Id: I86a6ff6052fda010c450c6ce8a96ec9465dfc952
Signed-off-by: Mélanie Bats <melanie.bats@obeo.fr>
The file was modified plugins/org.eclipse.eef.ide.ui/src/org/eclipse/eef/ide/ui/internal/widgets/RadioGroup.java
Commit bfd397498306db8b66de44c711914451a289ccd1 by Pierre-Charles David
Add missing Javadoc to avoid CheckStyle error

Change-Id: I1da92296935b90103412ffb013c0e4909674cefa
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
The file was modified plugins/org.eclipse.eef.ide.ui/src/org/eclipse/eef/ide/ui/internal/widgets/RadioGroup.java
Commit cee1cf082b5f96e59e1bc19aa8f32f23735fa32b by Stephane Begaudeau
Add support for null values in combos

JFace ComboViewers do not like null values in their possible choices,
but null is a legitimate choice for optional references (meaning
"unset"). Replace nulls with a special value (with no risk of conflict
with anything elese) when filling the combo, and convert it back to null
when passing it to the controller if the users chooses it.

Also avoid triggering the controller's updateValue() callback during
refresh when we configure the combo to show the current value.

Change-Id: Ic3d4f53f8c7f5c11a6aee02ef59708024bd63154
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
The file was modified plugins/org.eclipse.eef.ide.ui/src/org/eclipse/eef/ide/ui/internal/widgets/EEFSelectLifecycleManager.java