Skip to content

Changes

Summary

  1. Prevent 'direct edit' tools to be invoked on text widget during the (details)
  2. Execute EEFViewImpl#initialize() outside of a command (details)
Commit 988a7008e430f697bbdd87fe6c241f933a586902 by Pierre-Charles David
Prevent 'direct edit' tools to be invoked on text widget during the rendering phase

Change-Id: Ifd3779a861cbbdeb809b0edaf2c109e40170cfff
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
The file was modified plugins/org.eclipse.eef.ide.ui/src/org/eclipse/eef/ide/ui/internal/widgets/EEFTextLifecycleManager.java
The file was modified plugins/org.eclipse.eef.properties.ui/src/org/eclipse/eef/properties/ui/api/EEFTabbedPropertySheetPage.java
Commit 2215835d7f91abc0c096662d71abce8b0b805ee3 by Pierre-Charles David
Execute EEFViewImpl#initialize() outside of a command

The method only touches EEF-specific models which are not physically
connected to e.g. a Sirius-owned editing domain.

Executing the command on the editing domain's stack offers no benefit in
our particular case: our objects are not inside any resources and do not
have a TransactionChangeRecorder attached. However it triggers all the
command stack's listeners, in particular all GMF actions (when in the
context of a Sirius diagram), who re-compute their enablement status at
significant runtime cost.

Executing the initialization directly significantly improves
performances.

Change-Id: I43cc8afa5ebe105747f242cacbcd635c3aaf5fa8
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
The file was modified plugins/org.eclipse.eef.core/src/org/eclipse/eef/core/internal/EEFViewImpl.java