Skip to content
[Jenkins]Jenkins
log in

Changes

#55 (Jan 27, 2024, 3:33:14 AM)

  1. increase binary-compatibility-check.version to 3.4.0 after release — Thomas Jaeckle / githubweb
  2. update logback — Thomas Jaeckle / githubweb
  3. search and count by post — Pieter-Jan Lanneer / githubweb
  4. added license headers for 2024 — Thomas Jaeckle / githubweb
  5. prepare JS client release — Thomas Jaeckle / githubweb

3.4.0 (Oct 17, 2023, 7:43:40 AM)

  1. prepare 3.3.0 release — Thomas Jaeckle / githubweb
  2. prepare 3.3.0 JS client release — Thomas Jaeckle / githubweb
  3. fix MergeThing command being used for creating new things did not respect "inlinePolicy" — Thomas Jaeckle / githubweb
  4. update used GitHub actions versions; k8s version matrix for Helm — Thomas Jaeckle / githubweb
  5. update maven names — Thomas Jaeckle / githubweb
  6. prepare Ditto 3.4.0 release — Thomas Jaeckle / githubweb
  7. fix Java client build after upstream changes in Ditto — Thomas Jaeckle / githubweb

3.3.0 (Jun 22, 2023, 7:19:59 AM)

  1. prepare Ditto 3.2.0 release for JS client — Thomas Jaeckle / githubweb
  2. updated developers sections — Thomas Jaeckle / githubweb
  3. post Ditto 3.2.0 release: update binary-compatibility-check to version 3.2.0 — Thomas Jaeckle / githubweb
  4. post Ditto 3.2.0 release: update SECURITY.md — Thomas Jaeckle / githubweb
  5. add ILike filter to JS library — Bob Claerhout / githubweb
  6. prepare Ditto JS client 3.2.1 release — Thomas Jaeckle / githubweb
  7. adjusted Eclipse Ditto domain to eclipse.dev/ditto — Thomas Jaeckle / githubweb

3.2.0 (Mar 7, 2023, 10:55:36 AM)

  1. fix ditto-client test about policy import "importable" flag — Thomas Jaeckle / githubweb
  2. fix unit test — Dominik Guggemos / githubweb
  3. Introduce options for java live message API — David Schwilk / githubweb
  4. Minor code review fixes — David Schwilk / githubweb
  5. adjusted copyright headers for next year — Thomas Jaeckle / githubweb
  6. update binary compatibility version to 3.1.0 — Thomas Jaeckle / githubweb
  7. Update SECURITY.md — noreply / githubweb
  8. Bump json5 from 2.2.1 to 2.2.3 in /javascript/lib/api — noreply / githubweb
  9. Bump json5 from 2.2.1 to 2.2.3 in /javascript/lib/node — noreply / githubweb
  10. Bump json5 from 2.2.1 to 2.2.3 in /javascript/lib/dom — noreply / githubweb
  11. Bump json5 from 1.0.1 to 1.0.2 in /javascript — noreply / githubweb
  12. updated github repository locations to new "eclipse-ditto" org — Thomas Jaeckle / githubweb
  13. Bump http-cache-semantics from 4.1.0 to 4.1.1 in /javascript — noreply / githubweb
  14. update contact information for Thomas Jaeckle in pom.xml — Thomas J??ckle / githubweb
  15. removed section in contributing about adding company name — noreply / githubweb
  16. added merge property to javascript client sdk — Pieter-Jan Lanneer / githubweb
  17. update developers information — Thomas Jaeckle / githubweb

3.1.0 (Dec 14, 2022, 8:34:02 AM)

  1. updated JS client CHANGELOG.md for upcoming Ditto 3.0.0 release — Thomas Jaeckle / githubweb
  2. post-release 3.0.0 commit: — Thomas Jaeckle / githubweb
  3. Adds a ClientReconnectingException which is thrown if the client is attempting a reconnect while a message should be sent. — David Schwilk / githubweb
  4. small typo fix — David Schwilk / githubweb
  5. Fix JavaDoc errors — David Schwilk / githubweb
  6. fix for TS2611 — Dirk Van Haerenborgh / githubweb
  7. updated changelog for Ditto JS client 3.0.1 — Thomas Jaeckle / githubweb
  8. prepared Ditto JS client 3.0.1 release — Thomas Jaeckle / githubweb
  9. add support for cursor param — Matthias Weirich / githubweb
  10. add tests — Matthias Weirich / githubweb
  11. return cursor in SearchThingsResponse — Matthias Weirich / githubweb
  12. throw error when both cursor/size and limit is set — Matthias Weirich / githubweb
  13. directly close&release OSS nexus repositories on Ditto release — Thomas Jaeckle / githubweb
  14. prepare Ditto-Clients 3.1.0 release — Thomas Jaeckle / githubweb

#44 (Sep 9, 2022, 4:09:28 AM)

  1. Move creation of single threaded executor back into ThingSearchSubscription for spec conformance (Rule 1.03) — Yufei Cai / githubweb
  2. Ditto 3.0 preparation: removed deprecated marked code and adjusted japicmp excludes accordingly — Thomas Jaeckle / githubweb
  3. updated used dependencies to latest bugfix versions — Thomas Jaeckle / githubweb
  4. updated readme.md with new website location — noreply / githubweb
  5. [#181] fix DITTO_DUMMY_AUTH_USER config resolving in DittoClientUsageExamples — Thomas Jaeckle / githubweb
  6. [#193] fixed responding to messages in JS client did not preserve the message "headers" — Thomas Jaeckle / githubweb
  7. [#169] added `ErrorResponse` type used as "reject" reason in order to access status code together with body — Thomas Jaeckle / githubweb
  8. update node versions to test with — noreply / githubweb
  9. add workflow_dispatch to nodejs action — noreply / githubweb
  10. update lerna and node versions to test against to 14, 16, 18 — Thomas Jaeckle / githubweb
  11. undid domain change for Ditto website — Thomas Jaeckle / githubweb
  12. removed copyright holders from NOTICE.md as they are not required to be listed — Thomas Jaeckle / githubweb

#43 (Aug 15, 2022, 6:02:05 AM)

  1. Add fieldSelector and option to RetrievePolicy — David Schwilk / githubweb
  2. Revert "Set revision to policy when it can be derived from the entity tag contained in the response headers" — David Schwilk / githubweb
  3. Remove accidentally added test — David Schwilk / githubweb
  4. review: deprecate WithSelectedFields in things model in favor in same interface in base model — Johannes Schneider / githubweb
  5. review: revert imports of WithSelectedFields interface to prevent api break — Johannes Schneider / githubweb
  6. added ™ — noreply / githubweb
  7. prepared Ditto-clients release 2.4.0 — Thomas Jaeckle / githubweb
  8. fixed some module/dependency mess by e.g: — Thomas Jaeckle / githubweb
  9. apply naming of Thing.getPolicyEntityId() to getPolicyId() — Thomas Jaeckle / githubweb
  10. moved GatewayException and its (rightful) implementations to new module "gateway-api" — Thomas Jaeckle / githubweb
  11. enhanced Ditto client by adding the option to configure a "default-namespace" — Thomas Jaeckle / githubweb
  12. aligned Jenkinsfile_multibranch_pipeline — Thomas Jaeckle / githubweb
  13. futher consolidate Jenkins_multibranch_pipeline — Thomas Jaeckle / githubweb
  14. Remove default namespace configuration — Yannic Klem / githubweb
  15. increase binary compatibility check version to 2.4.0 — noreply / githubweb
  16. fixed nullable expectations if live.commands.modify package — Thomas Jaeckle / githubweb
  17. made MessageMapper aware of additional inbound headers to pass additional headers — Thomas Jaeckle / githubweb
  18. excluded ThingSearchPublisher method from japicmp-check — Thomas Jaeckle / githubweb
  19. Ditto 3.0 preparation: removed deprecated marked code and adjusted japicmp excludes accordingly — Thomas Jaeckle / githubweb
  20. added japicmd exclusion — Thomas Jaeckle / githubweb
  21. Revert "added japicmd exclusion" — Thomas Jaeckle / githubweb
  22. Revert "Ditto 3.0 preparation: removed deprecated marked code and adjusted japicmp excludes accordingly" — Thomas Jaeckle / githubweb
  23. Manually shutdown the executor of ThingSearchSubscription. — Yufei Cai / githubweb
  24. Transfer ownership of the executor of ThingSearchSubscription to its subscriber to be spec-conform. — Yufei Cai / githubweb

#41 (Mar 30, 2022, 4:42:49 AM)

  1. prepare Ditto JS client release 2.3.0 — Thomas Jaeckle / githubweb
  2. upgrade dependencies — Yannic Klem / githubweb
  3. updated Ditto JS client CHANGELOG.md — Thomas Jaeckle / githubweb
  4. set next "binary-compatibility-check.version" to released 2.3.0 — Thomas Jaeckle / githubweb
  5. Set revision to policy when it can be derived from the entity tag contained in the response headers — Yannic Klem / githubweb
  6. update nexus-staging-maven-plugin — noreply / githubweb
  7. update dependencies — Thomas Jaeckle / githubweb
  8. added python client to readme.md — noreply / githubweb
  9. added go reference badge to Go client section — noreply / githubweb

2.2.0 (Nov 23, 2021, 10:55:41 AM)

  1. Prepare changelog for the 2.1.0 release of the JS client — Florian Fendt / githubweb
  2. eclipse/ditto#898: added ditto-placeholders to assembly.xml as it is now a transitive dependency of ditto-protocol — Thomas Jaeckle / githubweb
  3. update 2.1.0 release date — Thomas Jaeckle / githubweb
  4. prepared Ditto JS client release 2.1.0 — Thomas Jaeckle / githubweb
  5. configured "binary-compatibility-check.version" version to 2.1.0 — Thomas Jaeckle / githubweb
  6. shutdown executor after stream cancellation — Johannes Schneider / githubweb
  7. Review: ensure executor shutdown in error case. — Yufei Cai / githubweb
  8. update Ditto JS Client "node" dependencies to their latest within their minor version — Thomas Jaeckle / githubweb
  9. prepare Ditto JS Client release 2.2.0 — Thomas Jaeckle / githubweb
  10. updated JS CHANGELOG.md for 2.2.0 changelog — Thomas Jaeckle / githubweb

2.1.0 (Sep 27, 2021, 5:20:48 AM)

  1. Replace WithDittoHeaders by DittoHeadersSettable. — Yufei Cai / githubweb
  2. Remove blocking instantiation of DittoClient — Yannic Klem / githubweb
  3. Replace return of CompletableFuture with CompletionStage — Yannic Klem / githubweb
  4. minor javadoc improvements; — Stefan Maute / githubweb
  5. change return type of merge functions to CompletionStage; — Stefan Maute / githubweb
  6. Remove instantiation of DittoRuntimeException — Yannic Klem / githubweb
  7. moved ditto live signals into ditto-java-client; — Stefan Maute / githubweb
  8. remove test dependency for ditto-signals-commands-live; — Stefan Maute / githubweb
  9. Switch status code of new exception back to how it was, BAD_REQUEST, because it was a mistake — Joel Bartelheimer / githubweb
  10. remove api 1 support — Yannic Klem / githubweb
  11. remov unnecessary osgi stuff for ditto-signals-commands-live — Yannic Klem / githubweb
  12. remove unused class — Yannic Klem / githubweb
  13. Adapt to the changes made in ditto regarding 'Fix WithId+WithIdButActuallyNot' — Joel Bartelheimer / githubweb
  14. Adapt to the changes, that RetrieveThings is not a ThingCommand anymore — Joel Bartelheimer / githubweb
  15. adjusted Ditto java client to changes of Event / EventsourcedEvent — Thomas Jaeckle / githubweb
  16. Review: — Yannic Klem / githubweb
  17. replace deprecated method call of getId() with getEntityName(); — Stefan Maute / githubweb
  18. removed APIs and code marked as "@deprecated" — Thomas Jaeckle / githubweb
  19. Adapt to EntityId changes in ditto — Yannic Klem / githubweb
  20. Prepare 2.0.0 release — Florian Fendt / githubweb
  21. fix raw generic type usages and other sonar issues — Thomas Jaeckle / githubweb
  22. Review: — Stefan Maute / githubweb
  23. fixed some sonar issues; — Stefan Maute / githubweb
  24. updated used dependencies + NOTICE-THIRD-PARTY.md — Thomas Jaeckle / githubweb
  25. added build and version badges to js readme — noreply / githubweb
  26. adjusted js version readme section — noreply / githubweb
  27. Adapt to restructured policies module in ditto — Yannic Klem / githubweb
  28. Adapt to things module restructuring in ditto — Yannic Klem / githubweb
  29. Adapt to restructured base module in ditto — Yannic Klem / githubweb
  30. Adapt to restructured thingsearch module in ditto — Yannic Klem / githubweb
  31. Adapt to message model restructuring in ditto — Yannic Klem / githubweb
  32. #667 add websocket auth provider for dom environments — Dominik Guggemos / githubweb
  33. fix test — Dominik Guggemos / githubweb
  34. fix test — Dominik Guggemos / githubweb
  35. review: renamed documented query param/header "x-ditto-dummy-auth" to "x-ditto-pre-authenticated" as the "dummy" is no longer available in Ditto 2.0 — Thomas Jaeckle / githubweb
  36. Adapt to moval of ditto-model-jwt — Yannic Klem / githubweb
  37. Adapt to moval of ditto-model-messages module — Yannic Klem / githubweb
  38. fix assembly.xml — Yannic Klem / githubweb
  39. Adapt RunOSGiContainerIntegrationTest to restructured modules and add missing module tests — Yannic Klem / githubweb
  40. fixed javadoc errors — Thomas Jaeckle / githubweb
  41. copied TestConstants from org.eclipse.ditto.things.model.signals.commands.TestConstants to client's "live" testcode — Thomas Jaeckle / githubweb
  42. use ${revision} again as ditto.version — Thomas Jaeckle / githubweb
  43. activate binary compatibility check to version 2.0.0 — Thomas Jaeckle / githubweb
  44. fix http connection — Vincenzo Territo / githubweb
  45. add new copyright holder — Vincenzo Territo / githubweb
  46. #156 add HTTP proxy for HTTP requests with the node client — Florian Fendt / githubweb
  47. #156 add basic tests for the node http requester — Florian Fendt / githubweb
  48. #157: fix encoding of search options, which did encode the sorting option twice — Florian Fendt / githubweb
  49. #157 send query params in node http requests — Florian Fendt / githubweb
  50. fixed RunOSGiContainerIntegrationTest by adding "org.eclipse.ditto:ditto-connectivity-model" module to the *bundles.zip used to bundle all transitive OSGi dependencies — Thomas Jaeckle / githubweb
  51. fixed RunOSGiContainerIntegrationTest by testing loading connectivity-model classes — Thomas Jaeckle / githubweb
  52. add reconnecting behaviour when an unintentional disconnect occures (this can happen when the gateway or nginx container get killed); — Stefan Maute / githubweb
  53. review: renamed atomicboolean + reset it to "false" when connection was (re-)established — Thomas Jaeckle / githubweb
  54. fix incorrect variable replacement for messageSubject in featureSelector; — Stefan Maute / githubweb
  55. add argumentNotNull check for type to registerForMessages implementations in LiveFeatureHandleImpl, LiveImpl and LiveThingHandleImpl; — Stefan Maute / githubweb
  56. updated eclipse jarsigner version to latest 1.3.1 — Thomas Jaeckle / githubweb
  57. enhance Ditto java client with a "disconnection listener" — Thomas Jaeckle / githubweb
  58. fixed NPE for ClientCredentialsAuthenticationProvider not providing a "jsonWebtokenSupplier" — Thomas Jaeckle / githubweb
  59. fixed compile error — Thomas Jaeckle / githubweb
  60. enhanced OSGi test for instantiating classes relying on ClassIndex import — Thomas Jaeckle / githubweb
  61. minor code formatting; — Stefan Maute / githubweb
  62. [#559] add condition option to ditto java client for thing operations; — Stefan Maute / githubweb
  63. release 2.1.0-M1 — Johannes Schneider / githubweb
  64. release 2.1.0-M2 — Johannes Schneider / githubweb
  65. [#559] remove usage of Condition class in ditto java client; — Stefan Maute / githubweb
  66. Issue #559: Refactored `OutgoingMessageFactory`. — Juergen Fickel / githubweb
  67. Issue #559: Extracted method for checking if option is allowed. — Juergen Fickel / githubweb
  68. fix unit test — Johannes Schneider / githubweb
  69. Issue #559: Extracted class for building DittoHeaders from options for particular outgoing message. — Juergen Fickel / githubweb
  70. Issue #559: Added empty lines to improve readability. Slightly adjusted some Javadoc comments. — Juergen Fickel / githubweb
  71. Issue #559: Widened type of condition argument to CharSequence. Adjusted Javadoc as well. — Juergen Fickel / githubweb
  72. Issue #559: Adjusted Javadoc of `ConditionOptionVisitor`. — Juergen Fickel / githubweb
  73. Issue #559: Made CONDITION a Global option as it is valid not only for modify commands but retrieve commands as well. — Juergen Fickel / githubweb
  74. fixed that for Java Runtime 8, using corePoolSize 0 leads to CPU usage of 100% — Thomas Jaeckle / githubweb

2.0.0 (May 4, 2021, 5:25:24 AM)

  1. Update IPLab URL. — Wayne Beaton / githubweb
  2. The review property no longer makes sense in the Maven plugin. — Wayne Beaton / githubweb

#33 (Apr 19, 2021, 3:36:16 AM)

  1. Skip duplicates. — Wayne Beaton / githubweb
  2. Make timeout configurable on the CLI. — Wayne Beaton / githubweb
  3. Support package-lock.json v2. — Wayne Beaton / githubweb

#32 (Apr 16, 2021, 9:17:42 AM)

  1. Prepare changelog for 3.0.0 — Florian Fendt / githubweb
  2. Update changelog for 3.0.0 — Florian Fendt / githubweb
  3. Merge changelog of 2.1.0 — Florian Fendt / githubweb
  4. Add bugfix #66 to the changelog for JS client 3.0.0 — Florian Fendt / githubweb
  5. Add bugfix #126 to the changelog for JS client 3.0.0 — Florian Fendt / githubweb
  6. Add feature #111 to the changelog for JS client 3.0.0 — Florian Fendt / githubweb
  7. Add feature #117 to the changelog for JS client 3.0.0 — Florian Fendt / githubweb
  8. Add #124 and #140 to the release changelog — Florian Fendt / githubweb
  9. Merge master into changelog_3.0.0 — Florian Fendt / githubweb
  10. Update CHANGELOG and READMEs for new 2.0.0 release — Florian Fendt / githubweb
  11. Add script to update the version — Florian Fendt / githubweb
  12. Prepare 2.0.0-M2 release — Florian Fendt / githubweb

#29 (Apr 16, 2021, 4:15:28 AM)

  1. Update dependencies — Florian Fendt / githubweb

#28 (Apr 15, 2021, 8:31:43 AM)

  1. #28 remove the IIFE build from the API and DOM modules — Florian Fendt / githubweb
  2. only serialize strings with quotation marks — Matthias Weirich / githubweb
  3. remove object serialization & fix serialization for In — Matthias Weirich / githubweb
  4. add support for _created field to thing model — Matthias Weirich / githubweb
  5. add tests for _created field — Matthias Weirich / githubweb
  6. create stringify function — Matthias Weirich / githubweb
  7. fix test for thing without metadata — Matthias Weirich / githubweb
  8. correct merge mistake — Matthias Weirich / githubweb
  9. correct merge mistake — Matthias Weirich / githubweb
  10. rename getter to _created — Matthias Weirich / githubweb
  11. update package-lock.json — Matthias Weirich / githubweb
  12. Publish all modules as ESM instead of a mix of ESM and CJS. — Florian Fendt / githubweb
  13. implement requested changes — Matthias Weirich / githubweb
  14. implement requested changes — Matthias Weirich / githubweb
  15. Export node client as commonjs module as ESM still has problems in node — Florian Fendt / githubweb
  16. Don't publish the API module — Florian Fendt / githubweb
  17. fix jest config — Florian Fendt / githubweb
  18. Remove ACL, which is only available in API 1 — Florian Fendt / githubweb
  19. Remove API 1 build steps, handles, client interfaces and implementations — Florian Fendt / githubweb
  20. Update node versions in GitHub actions — Florian Fendt / githubweb
  21. Remove karma conf — Florian Fendt / githubweb
  22. removed unused function, fixed imports in test — Johannes Schneider / githubweb

2.0.0-M2 (Apr 8, 2021, 6:21:17 AM)

  1. Increase test coverage. — Wayne Beaton / githubweb
  2. Improve tests. — Wayne Beaton / githubweb
  3. Fix NPE in LicenseSupport — Alexander Kurtakov / githubweb
  4. Use a version of maven-deploy that actually exists — Wayne Beaton / githubweb
  5. Use Collection.isEmpty method. — Alexander Kurtakov / githubweb
  6. Build with JUnit 5.7.1 — Alexander Kurtakov / githubweb
  7. Use maven-common-artifact-filters 3.2.0 — Alexander Kurtakov / githubweb
  8. Plugin is published to repository. — Alexander Kurtakov / githubweb
  9. Do not inherit license-check mojo — Alexander Kurtakov / githubweb
  10. Add detailed instructions for Maven usage — Alexander Kurtakov / githubweb
  11. Provide better defaults. — Wayne Beaton / githubweb
  12. Protect against NPE. — Wayne Beaton / githubweb
  13. Add (experimental) support for reading yarn.lock files — Wayne Beaton / githubweb
  14. Update README — Wayne Beaton / githubweb
  15. Include Java 11 requirement in README. — Wayne Beaton / githubweb
  16. Update README.md — noreply / githubweb
  17. Update README.md — noreply / githubweb
  18. Update README.md — noreply / githubweb
  19. Update README.md — noreply / githubweb
  20. Update README.md — noreply / githubweb
  21. Update README.md — noreply / githubweb

#26 (Apr 8, 2021, 6:19:48 AM)

  1. test adding metadata — Matthias Weirich / githubweb
  2. create dedicated metadata class — Matthias Weirich / githubweb
  3. fix tslint error — Matthias Weirich / githubweb
  4. new metadata class — Matthias Weirich / githubweb
  5. fix order of attributes and features in metadata — Matthias Weirich / githubweb
  6. add tests for _metadata — Matthias Weirich / githubweb
  7. fix linter errors — Matthias Weirich / githubweb
  8. don't include _metadata on thing serialization — Matthias Weirich / githubweb
  9. Do adapt extracting of Live-Response from acknowledgement — Yannic Klem / githubweb
  10. fix sonar issue; — Stefan Maute / githubweb
  11. switch back to maven surefire- and failsafe-plugins 3.0.0-M4 — noreply / githubweb
  12. resolve conflicts with master — Matthias Weirich / githubweb
  13. move _metadata to end of constructor param list — Matthias Weirich / githubweb
  14. consolidated dependencies by using same dependency versions as in Ditto — Thomas Jaeckle / githubweb
  15. fixed NOTICE.md and exclude poms from being added to created client .jar — Thomas Jaeckle / githubweb
  16. fix OSGi test / imports — Thomas Jaeckle / githubweb
  17. added option to manually start master build — noreply / githubweb
  18. added Go client to toplevel readme — noreply / githubweb

#17 (Feb 9, 2021, 10:18:26 AM)

  1. Add a new optional step to set a custom api path — Matthias Weirich / githubweb
  2. add tests — Matthias Weirich / githubweb
  3. document new builder step — Matthias Weirich / githubweb
  4. improved "loadtest" scenario on DittoClientUsageExamples — Thomas Jaeckle / githubweb
  5. set DittoClientUsageExamples back to invoking all usage examples, not only the modifided loadtest — Thomas Jaeckle / githubweb
  6. fixed license declaration of Ditto JavaScript client in package.json files — Thomas Jaeckle / githubweb
  7. consolidate/update test dependencies — Thomas Jaeckle / githubweb

#16 (Feb 9, 2021, 10:13:47 AM)

  1. Increase test coverage. Includes some refactoring. — Wayne Beaton / githubweb

#6 (Feb 8, 2021, 8:32:35 AM)

  1. Refactoring. — Wayne Beaton / githubweb
  2. Fix the Maven settings. — Wayne Beaton / githubweb
  3. Include information from the npmjs repository in the review request. — Wayne Beaton / githubweb
  4. Mock out the HTTP call to test ClearlyDefined support. — Wayne Beaton / githubweb
  5. Actually enable the interesting test. — Wayne Beaton / githubweb

#5 (Feb 5, 2021, 7:34:47 AM)

  1. expose thing definition — Dirk Van Haerenborgh / githubweb
  2. add test for definition — Dirk Van Haerenborgh / githubweb
  3. implement GET/PUT/DELETE definition — Dirk Van Haerenborgh / githubweb
  4. fix model test — Dirk Van Haerenborgh / githubweb
  5. fix test for get definition — Dirk Van Haerenborgh / githubweb
  6. add tet for creating definition — Dirk Van Haerenborgh / githubweb
  7. fix linter errors — Dirk Van Haerenborgh / githubweb