Skip to content
[Jenkins]Jenkins
log in

Changes

Summary

  1. [#559] add condition option to ditto java client for thing operations; (details)
  2. [#559] remove usage of Condition class in ditto java client; (details)
  3. Issue #559: Refactored `OutgoingMessageFactory`. (details)
  4. Issue #559: Extracted method for checking if option is allowed. (details)
  5. Issue #559: Extracted class for building DittoHeaders from options for particular outgoing message. (details)
  6. Issue #559: Added empty lines to improve readability. Slightly adjusted some Javadoc comments. (details)
  7. Issue #559: Widened type of condition argument to CharSequence. Adjusted Javadoc as well. (details)
  8. Issue #559: Adjusted Javadoc of `ConditionOptionVisitor`. (details)
  9. Issue #559: Made CONDITION a Global option as it is valid not only for modify commands but retrieve commands as well. (details)
  10. fixed that for Java Runtime 8, using corePoolSize 0 leads to CPU usage of 100% (details)
Commit 413231a2a8021b8acb9b243e8d7d46799582725f by Stefan Maute
[#559] add condition option to ditto java client for thing operations;
extend unit tests;

Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/internal/OutgoingMessageFactory.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientUsageExamples.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/options/Options.java (diff)
The file was addedjava/src/main/java/org/eclipse/ditto/client/options/internal/ConditionOptionVisitor.java
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientAttributesTest.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientFeaturesTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/options/internal/OptionsEvaluator.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientThingTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/options/OptionName.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientPoliciesTest.java (diff)
Commit 3c8ae0304fe077675297970dc795ee0ce01c77dc by Stefan Maute
[#559] remove usage of Condition class in ditto java client;

Signed-off-by: Stefan Maute <stefan.maute@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/options/internal/OptionsEvaluator.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientPoliciesTest.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientThingTest.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientFeaturesTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/options/internal/ConditionOptionVisitor.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientAttributesTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/options/Options.java (diff)
Commit 24607568954eddac2f8ac86a06c176cf0447bfa9 by Juergen Fickel
Issue #559: Refactored `OutgoingMessageFactory`.
* Formatted code.
* When building DittoHeaders, the allowed options now are not a bunch of boolean arguments but a collection containing the allowed options. This makes it easier to scale the allowed options.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/internal/OutgoingMessageFactory.java (diff)
Commit a6e9cd657560a7cea107a223e7061063b24e27ef by Juergen Fickel
Issue #559: Extracted method for checking if option is allowed.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/internal/OutgoingMessageFactory.java (diff)
Commit d61b240aa9514c08be6730a24c70b7a6abc8a6cf by Juergen Fickel
Issue #559: Extracted class for building DittoHeaders from options for particular outgoing message.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
The file was addedjava/src/main/java/org/eclipse/ditto/client/internal/OptionsToDittoHeaders.java
The file was addedjava/src/test/java/org/eclipse/ditto/client/internal/OptionsToDittoHeadersTest.java
The file was modified java/src/main/java/org/eclipse/ditto/client/internal/OutgoingMessageFactory.java (diff)
Commit 987afbfaf0fa8fff5941915af301335983b78e66 by Juergen Fickel
Issue #559: Added empty lines to improve readability. Slightly adjusted some Javadoc comments.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/options/OptionName.java (diff)
Commit 0eae873f3d780c65924b30842dc522ff25c1cc7a by Juergen Fickel
Issue #559: Widened type of condition argument to CharSequence. Adjusted Javadoc as well.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/options/Options.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientAttributesTest.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientFeaturesTest.java (diff)
Commit deee5387c8c8086022e8d26e6459709686f626c4 by Juergen Fickel
Issue #559: Adjusted Javadoc of `ConditionOptionVisitor`.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/options/internal/ConditionOptionVisitor.java (diff)
Commit 9af56d09fd1a7f1dfa08a90d3a3764d11486fa1c by Juergen Fickel
Issue #559: Made CONDITION a Global option as it is valid not only for modify commands but retrieve commands as well.
Added the possibility to specify options for retrieving a thing or a feature.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/internal/OutgoingMessageFactory.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/internal/OptionsToDittoHeadersTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/management/ThingHandle.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/management/CommonManagement.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/options/Options.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/options/internal/OptionsEvaluator.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/options/internal/ConditionOptionVisitor.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientFeaturesTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/internal/OptionsToDittoHeaders.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/management/internal/ThingHandleImpl.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientAttributesTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/options/OptionName.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientPoliciesTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/management/internal/FeatureHandleImpl.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/internal/CommonManagementImpl.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/management/FeatureHandle.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientThingTest.java (diff)
Commit 59609ef4953ddd20584415b5a74695073aecc450 by Thomas Jaeckle
fixed that for Java Runtime 8, using corePoolSize 0 leads to CPU usage of 100%
* known bug for Java 8: https://bugs.openjdk.java.net/browse/JDK-8129861
* use corePoolSize 0 for a Java Runtime > 8

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/messaging/MessagingProviders.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/messaging/internal/WebSocketMessagingProvider.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/internal/VersionReader.java (diff)