Skip to content
[Jenkins]Jenkins
log in

Changes

Summary

  1. Issue eclipse/ditto#757: adjusted signature according to Ditto generic type changes (details)
  2. Allows to acknowledge live messages (details)
  3. fix failing unit tests (details)
  4. Issue #757: extend message sending to handle acknowledgements. (details)
  5. Issue #ditto/757: Allow sending of live commands with any ack requests including live-response; test it; test subscribing for messages and sending acknowledgements. (details)
  6. Issue #757: add test for message sender's handling of error responses and fix it. (details)
  7. Issue #ditto/757: Add acknowledgements to live commands. (details)
  8. Issue #ditto/757: fix double-lookup. (details)
  9. Issue #ditto/757: fix license and binary compatibility problems. (details)
  10. Issue #ditto/757: un-deprecate 2 methods in MessageSender - they are actually used to send responses, which have no response of their own anyway. (details)
  11. Aligned handling of acknowledgements for live messages with the (details)
  12. handle ErrorResponse correctly (details)
  13. Issue #ditto/757: always throw IllegalStateException on missing expected acknowledgement label; throw IllegalArgumentException when told to send signals with missing acknowledgement requests. (details)
Commit 6f21fba6690d4b4c73ea8b57ef45fdd84e7a72ef by Thomas Jaeckle
Issue eclipse/ditto#757: adjusted signature according to Ditto generic type changes

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/internal/AbstractHandle.java (diff)
Commit 2ee7724dbed3ed106aa8d322fbf58f2ee62796e4 by Yannic Klem
Allows to acknowledge live messages

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
The file was removedjava/src/main/java/org/eclipse/ditto/client/changes/internal/ImmutableAcknowledgementRequestHandle.java
The file was modified java/src/test/java/org/eclipse/ditto/client/changes/internal/ImmutableAcknowledgementRequestHandleTest.java (diff)
The file was addedjava/src/main/java/org/eclipse/ditto/client/ack/internal/ImmutableAcknowledgementRequestHandle.java
The file was modified java/src/main/java/org/eclipse/ditto/client/changes/Change.java (diff)
The file was addedjava/src/main/java/org/eclipse/ditto/client/ack/Acknowledgeable.java
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/internal/ImmutableMessageSender.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/changes/internal/ImmutableChange.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/internal/ImmutableDeserializingMessage.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/internal/OutgoingMessageFactory.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/internal/PendingMessageImpl.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/MessageSender.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/RepliableMessage.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/internal/ImmutableRepliableMessage.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/internal/LiveMessagesUtil.java (diff)
Commit 15ff619a73e493d875b64a71eeefcb3cd9c9e4a0 by Yannic Klem
fix failing unit tests

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/live/internal/PendingMessageImpl.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/live/messages/internal/ImmutableRepliableMessageTest.java (diff)
Commit 300b52475553de10c132e98984af7f9622611c0a by Yufei Cai
Issue #757: extend message sending to handle acknowledgements.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/MessageSender.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/ChangeUpwardsDownwardsPropagationTest.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/internal/AbstractDittoClientTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/internal/ImmutableRepliableMessage.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientLiveTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/internal/PendingMessageImpl.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/internal/ImmutableDeserializingMessage.java (diff)
The file was addedjava/src/main/java/org/eclipse/ditto/client/ack/ResponseConsumer.java
The file was modified java/src/main/java/org/eclipse/ditto/client/internal/OutgoingMessageFactory.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/internal/ImmutableMessageSender.java (diff)
Commit 05b9b99bf5ebc080c153e94700d42880298dbcd9 by Yufei Cai
Issue #ditto/757: Allow sending of live commands with any ack requests including live-response; test it; test subscribing for messages and sending acknowledgements.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientThingTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/twin/internal/TwinThingHandleImpl.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/twin/internal/TwinSearchHandleImpl.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/twin/internal/TwinFeatureHandleImpl.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientAttributesTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/internal/LiveImpl.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/internal/AbstractDittoClientThingsTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/twin/internal/TwinImpl.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/policies/internal/PoliciesImpl.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientLiveTest.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientFeaturesTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/internal/AbstractHandle.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/internal/LiveThingHandleImpl.java (diff)
The file was addedjava/src/test/java/org/eclipse/ditto/client/DittoClientTwinTest.java
The file was modified java/src/main/java/org/eclipse/ditto/client/live/internal/LiveFeatureHandleImpl.java (diff)
Commit 4c3c3e185258de5bb62f92321e53811d537f57af by Yufei Cai
Issue #757: add test for message sender's handling of error responses and fix it.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/ack/ResponseConsumer.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientLiveTest.java (diff)
Commit b285baf3a1ce6ce0f176d76a7a00583c2703935d by Yufei Cai
Issue #ditto/757: Add acknowledgements to live commands.

For usage example, see:

DittoClientLiveTest.testThingCommandAcknowledgement().

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientLiveTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/changes/internal/ImmutableThingChange.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/commands/ThingAttributesCommandHandling.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/commands/ThingCommandHandling.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/changes/internal/ImmutableFeatureChange.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/ack/internal/ImmutableAcknowledgementRequestHandle.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/internal/LiveThingHandleImpl.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/LiveCommandProcessor.java (diff)
The file was addedjava/src/main/java/org/eclipse/ditto/client/live/commands/LiveCommandHandlerImpl.java
The file was modified java/src/main/java/org/eclipse/ditto/client/live/internal/LiveImpl.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/commands/FeaturePropertiesCommandHandling.java (diff)
The file was removedjava/src/main/java/org/eclipse/ditto/client/changes/AcknowledgementRequestHandle.java
The file was modified java/src/main/java/org/eclipse/ditto/client/live/commands/FeaturesCommandHandling.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/changes/internal/ImmutableChange.java (diff)
The file was addedjava/src/main/java/org/eclipse/ditto/client/live/commands/LiveCommandHandler.java
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/internal/ImmutableRepliableMessage.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/ack/Acknowledgeable.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/internal/LiveFeatureHandleImpl.java (diff)
The file was addedjava/src/main/java/org/eclipse/ditto/client/live/commands/LiveCommandAcknowledgeable.java
The file was modified java/src/main/java/org/eclipse/ditto/client/live/commands/ThingsCommandHandling.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/changes/Change.java (diff)
The file was addedjava/src/main/java/org/eclipse/ditto/client/ack/AcknowledgementRequestHandle.java
The file was modified java/src/main/java/org/eclipse/ditto/client/changes/internal/ImmutableFeaturesChange.java (diff)
Commit acbeefb45ed9fe7e0ec1da9736cc43ff1e465c7d by Yufei Cai
Issue #ditto/757: fix double-lookup.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/live/LiveCommandProcessor.java (diff)
Commit 1cb260b60aa58e7fdc7b703261b7b510ee8fcdec by Yufei Cai
Issue #ditto/757: fix license and binary compatibility problems.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/live/commands/LiveCommandAcknowledgeable.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/internal/ImmutableRepliableMessage.java (diff)
The file was addedjava/src/main/java/org/eclipse/ditto/client/changes/AcknowledgementRequestHandle.java
The file was removedjava/src/main/java/org/eclipse/ditto/client/ack/AcknowledgementRequestHandle.java
The file was modified java/src/main/java/org/eclipse/ditto/client/changes/internal/ImmutableThingChange.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/ack/Acknowledgeable.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/ack/internal/ImmutableAcknowledgementRequestHandle.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/changes/internal/ImmutableFeaturesChange.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/changes/internal/ImmutableChange.java (diff)
The file was modified java/pom.xml (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/changes/internal/ImmutableFeatureChange.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/commands/LiveCommandHandlerImpl.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/commands/LiveCommandHandler.java (diff)
Commit 83ac86ee23893fa8d7b3dfab3f2a4acecd394ca0 by Yufei Cai
Issue #ditto/757: un-deprecate 2 methods in MessageSender - they are actually used to send responses, which have no response of their own anyway.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/MessageSender.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/internal/ImmutableMessageSender.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/internal/LiveMessagesUtil.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/internal/HandlerRegistry.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientLiveTest.java (diff)
Commit 01098f35cb5baf27339430dae9c47b83a895630e by Yannic Klem
Aligned handling of acknowledgements for live messages with the
handling of acknowledgements for thing commands

* Removed newly introduced method sendWithExpectedAcknowledgement
* Extract live response out of acknowledgements object

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/MessageSender.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/internal/ImmutableMessageSender.java (diff)
Commit b598297a168ef1d27af69eb123aa620ed371807e by Yannic Klem
handle ErrorResponse correctly

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/internal/ImmutableMessageSender.java (diff)
Commit d2457f877696852f392e83c551df3d12dab49cb1 by Yufei Cai
Issue #ditto/757: always throw IllegalStateException on missing expected acknowledgement label; throw IllegalArgumentException when told to send signals with missing acknowledgement requests.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
The file was modified java/src/main/java/org/eclipse/ditto/client/internal/AbstractHandle.java (diff)
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientLiveTest.java (diff)
The file was modified java/src/main/java/org/eclipse/ditto/client/live/messages/internal/ImmutableMessageSender.java (diff)
The file was addedjava/src/main/java/org/eclipse/ditto/client/ack/internal/AcknowledgementRequestsValidator.java
The file was modified java/src/test/java/org/eclipse/ditto/client/DittoClientThingTest.java (diff)